Use model error_messages when available #3435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the automatically applied UniqueValidator, use the error message from error_messages defined in the model instead of the generic default UniqueValidator message. This fixes encode#2878.
|
Seems reasonable. |
tomchristie
added a commit
that referenced
this pull request
Sep 24, 2015
Use model error_messages when available
| unique_error_message = model_field.error_messages.get('unique', None) | ||
| if unique_error_message: | ||
| unique_error_message = unique_error_message % { | ||
| 'model_name': model_field.model._meta.object_name, |
There was a problem hiding this comment.
django uses capfirst for verbose_name would such change be accepted?
There was a problem hiding this comment.
Most probably yup! (Could you point out an example of exactly where/what first tho?)
There was a problem hiding this comment.
I'm not sure what you would like to see. Is it this?
There was a problem hiding this comment.
Perfect, yup. If you do choose to submit a fix for this it'll also be worth double checking if there's any other errors messages where we should also be doing capfirst(opts.verbose_name).
6 tasks
This was referenced Mar 9, 2017
This was referenced Oct 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the automatically applied UniqueValidator, use the error message from
error_messages defined in the model instead of the generic default
UniqueValidator message.
This fixes #2878.