Add compat util for DecimalValidator #3568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What annoys me the most here is that this part doesn't seem to be covered by a test. |
|
@xordoquy was just checking on that, we have some tests that did get close but since those DecimalField had no validators we didn't have that covered because of the list comprehension. Should I put together a regression test? |
|
Would be nice to have I think. |
|
@xordoquy there added some tests that should have covered the problem. |
xordoquy
added a commit
that referenced
this pull request
Oct 30, 2015
Add compat util for DecimalValidator
|
Nice job ! |
|
👍 |
This was referenced Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DecimalValidator was introduced in Django 1.9.
Resolves #3562