Request parsing when .POST accessed

[tomchristie]

Closes #3574.

[babinos87]

Hi. Not sure if my issue is related to this fix, but this is what I have found til that moment.

Today I upgraded my DRF version to 3.3.1. In my application, I use django-rest-auth (version 0.5.0)
and django-allauth (version 0.24.1) for the sign-up mechanism that my app uses. Until now, the sign-up was working fine in version 3.2.3 that I used. After upgrading to 3.3.1, sign-up brokes. Trying to trace the issue, what I get as response is:

Request Method: POST
Request URL: http://localhost:8000/api/auth/registration/
Django Version: 1.8.6
Exception Type: AttributeError
Exception Value: can't set attribute

And it point to me at line 54 of views.py of rest-auth package:

rest_auth/registration/views.py Line 54 is:

self.request.POST = self.request.data.copy()

So, the above statement fails for DRF 3.3.1, although it was working in 3.2.3

Do you know why this could be failing? Should the changes you made for this bug affect the above command somehow?

Probably if this is the case there should be an update for allauth as I understand it is not your responsibility, but just wondering why after upgrading to DRF 3.3.1 got that issue, and any ideas on how I can overcome this.

Regards,
Babis

[babinos87]

Tried in both versions (3.3.1 and 3.2.3) and the self.request.data object is the same in both versions. So I suppose what fails is the assignment to the self.request.POST?

[babinos87]

The definition of post method in the file rest_auth/registration/views.py:

def post(self, request, *args, **kwargs):
    self.initial = {}
    self.request.POST = self.request.data.copy()     # This line breaks
    form_class = self.get_form_class()
    self.form = self.get_form(form_class)
    if self.form.is_valid():
        self.form_valid(self.form)
        return self.get_response()
    else:
        return self.get_response_with_errors()

[babinos87]

ok, found out that rest-auth had an issue with that upgrade, but the fix is out there, managed to update my rest-auth source and resolve my issue. False alarm then :)

Cheers