Fix regression causing raw data form to not display #3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this looks right - any chance you could add a screenshot and just round out the description a little? |
|
@tomchristie Added some detail to clarify |
|
Thanks for the PR ! |
xordoquy
added a commit
that referenced
this pull request
Nov 13, 2015
Fix regression causing raw data form to not display
This was referenced Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
34eb18b introduced #3578 that causes raw data form to not display when there is no html form tab.
This change reverts a specific change in the referred to commit that changed the logic of when to show the HTML and|or Raw Data POST forms as tabs in the API browser.
The correct logic is to show the Raw Data form as a tab if there is also an HTML form to render (i.e. there's two tabs in total). Otherwise display the Raw Data form as an unstyled div.
The faulty logic attempted to show the the Raw Data form as a tab whether or not there was a second tab containing the HTML form. As a result of Bootstrap's default styling on tab-pane (display: none), the raw data form would not be displayed.
See #3578 for screenshots.