Fix template.render deprecation warnings for Django 1.9 #3654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| context = RequestContext(renderer_context['request'], context) | ||
| ret = template.render(context) | ||
| else: | ||
| ret = template.render(context, request=renderer_context['request']) |
There was a problem hiding this comment.
This should go to the compat.py file and should be similar to the new API.
|
Thanks for fixing this. I think the code should be moved to compat.py and be given an API similar to Django's new one. |
|
Ok, I fix |
andreif
force-pushed
the
fix/deprecation-warning-1.9
branch
from
3bf5dfd to
802ee5d
Compare
|
@xordoquy Done. |
|
Looks good - thanks! |
tomchristie
added a commit
that referenced
this pull request
Nov 18, 2015
Fix template.render deprecation warnings for Django 1.9
|
We're trying to switch to Django 1.8 using django-jinja which expects to be passed a request to the render method. I was wondering if the condition whether to pass in the request could be modified in DRF to be checking for |
|
Indeed, this seems to have slip through. |
|
@jezdez thanks for the report ! |
This was referenced Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
RequestContexttoTemplate.renderis deprecated, see django/django#3883https://github.com/django/django/blob/1.9rc1/django/template/backends/django.py#L82-L84