-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3228 - add confirm modal for delete #3662
Conversation
@awwester this is great! Mind putting together a screenshot or gif? Might also be a good idea to wrap new strings in a |
This is my first time working with translations and although the code seems correct comparing with other instances, I'm having issues getting a positive test to be sure. I've added a couple settings according to http://www.django-rest-framework.org/topics/internationalization/#enabling-internationalized-apis but can't get my app to switch into spanish for testing.
is there something I'm missing? |
@awwester sorry for the delay. To move this forward faster, I'd say forget about adding translation tags, drop the |
@jpadilla The trans changes have been reverted |
@tomchristie @xordoquy any feedback? If it looks good, I'm merging. |
No objection from me. |
#3228 - add confirm modal for delete
@awwester thanks again 🎆 |
Added a modal to confirm deletion of data