QueryParameterVersioning does not use DEFAULT_VERSION setting
#3833
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QueryParameterVersioning does not fall back to the value used in the `DEFAULT_VERSION` setting, while other versioning schemes do. This looks like a minor change, and incorporates the `self.default_version` set in the superclass. I'll sheepishly admit that I edited this inline without running any tests or anything, so please let me know if this needs more work.
xordoquy
added a commit
that referenced
this pull request
Jan 14, 2016
QueryParameterVersioning does not use default version
|
Thanks for fixing this ! |
|
You're welcome 👍 |
xordoquy
changed the title
DEFAULT_VERSION setting
This was referenced Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QueryParameterVersioning does not fall back to the value used in the
DEFAULT_VERSIONsetting, while other versioning schemes do. This looks like a minor change, and incorporates theself.default_versionset in the superclass.I'll sheepishly admit that I edited this inline without running any tests or anything, so please let me know if this needs more work.