Added support for custom CSRF cookie names #4049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -230,6 +230,9 @@ <h4 class="modal-title" id="myModalLabel">{{ error_title }}</h4> | |||
| {% if filter_form %}{{ filter_form }}{% endif %} | |||
|
|
|||
| {% block script %} | |||
| <script> | |||
| var csrf_cookie_name = "{{ csrf_cookie_name|default:'csrftoken' }}"; | |||
There was a problem hiding this comment.
Could we instead do something like:
window.drf = {
csrfCookieName: "{{ csrf_cookie_name|default:'csrftoken' }}"
};and use window.drf.csrfCookieName in csrf.js?
|
Good stuff @clintonb, just left one small comment. |
|
This reminds me, I should probably do some house cleaning of our client side stuff. |
Instead of hardcoding the CSRF cookie name, the value is passed to the template as a context variable, rendered as a JavaScript variable, and read by csrf.js. Fixes #4048
|
@jpadilla I addressed your comment. Let me know if any other changes are necessary to merge. |
|
@clintonb thanks! |
This was referenced Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding the CSRF cookie name, the value is passed to the template as a context variable, rendered as a JavaScript variable, and read by csrf.js.
refs #4048