Exclude read_only=True fields from unique_together validation & add docs. #4192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchristie
changed the title
tomchristie
deleted the
exclude-read-only-fields-from-unique-together-validation
branch
6 tasks
punchagan
added a commit
to akvo/akvo-rsr
that referenced
this pull request
Nov 15, 2017
unique_together constraint seems to make the fields that are a part of it hidden, even when they are marked as read_only. This commit adds a work around, to fix this bug. Using the patch from encode/django-rest-framework#4192 didn't seem to work. There are other changes, possibly, that cause this code to not work in the version of DRF we are using.
punchagan
added a commit
to akvo/akvo-rsr
that referenced
this pull request
Nov 16, 2017
unique_together constraint seems to make the fields that are a part of it hidden, even when they are marked as read_only. This commit adds a work around, to fix this bug. Using the patch from encode/django-rest-framework#4192 didn't seem to work. There are other changes, possibly, that cause this code to not work in the version of DRF we are using.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2848
Docs update closes #2996
Docs update closes #3970