Minor refactoring of must_call_distinct
#4215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Filtering against a many-to-many field requires us to | ||
| # call queryset.distinct() in order to avoid duplicate items | ||
| # in the resulting queryset. | ||
| # We try to avoid this is possible, for performance reasons. |
There was a problem hiding this comment.
We try to avoid this if possible, for performance reasons.
Current coverage is 91.51%@@ master #4215 diff @@
==========================================
Files 51 51
Lines 5537 5538 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 5067 5068 +1
Misses 470 470
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.