Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup_type is deprecated in favor of lookup_expr #4259

Merged
merged 1 commit into from
Jul 13, 2016

Conversation

atombrella
Copy link
Contributor

assertEquals is deprecated in favor of assertEqual

app_name is a required keyword as of Django 1.10

assertEquals is deprecated in favor of assertEqual

app_name is a required keyword as of Django 1.10
@atombrella
Copy link
Contributor Author

These are different warnings that I found when running the test suite with the -Wall flag (I verified that the tests run both on Python 2 and 3). I don't know if each replacement should be a separate commit or if this is acceptable.

@codecov-io
Copy link

codecov-io commented Jul 13, 2016

Current coverage is 91.23%

Merging #4259 into master will not change coverage

@@             master      #4259   diff @@
==========================================
  Files            52         52          
  Lines          5776       5776          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           5270       5270          
  Misses          506        506          
  Partials          0          0          

Powered by Codecov. Last updated by 549210b...ff49667

@tomchristie tomchristie added this to the 3.4.0 Release milestone Jul 13, 2016
@tomchristie tomchristie merged commit 6defb8d into encode:master Jul 13, 2016
@tomchristie
Copy link
Member

Good stuff, thanks!

@xordoquy
Copy link
Collaborator

provided we use py.test, we should just get rid of assert**** and simply use assert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants