Fix handling of ALLOWED_VERSIONS and no DEFAULT_VERSION #4370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. |
When only `ALLOWED_VERSIONS` but no `DEFAULT_VERSION` is specified, a version should be enforced. When changing this, no existing tests were failing. This adds tests for the fixed behavior. The old behavior can be restored by adding `None` explicitly to `ALLOWED_VERSIONS`.
blueyed
force-pushed
the
fix-None-default-version
branch
from
e5aac43 to
a69f4bc
Compare
|
Amended. |
|
Not amended correctly. Please squash-merge it into a single commit then, or let me know if I should fix it up / amend it correctly. |
|
Yup, looks good - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When only
ALLOWED_VERSIONSbut noDEFAULT_VERSIONis specified, aversion should be enforced. When changing this, no existing tests were
failing. This adds tests for the fixed behavior.
The old behavior can be restored by adding
Noneexplicitly toALLOWED_VERSIONS.