Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - initial work to support django 2.0 #5442

Closed
wants to merge 6 commits into from
Closed

Conversation

auvipy
Copy link
Member

@auvipy auvipy commented Sep 22, 2017

work in progress. initial attempt to support dj v2. some more failures will be fixed after the release one by one

Copy link
Member Author

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im quite not sure about the proper fixes for the failures in 2.x version. could you suggest some light

@auvipy
Copy link
Member Author

auvipy commented Sep 23, 2017

seems like some pytest related issues need to be addressed

@carltongibson
Copy link
Collaborator

@auvipy Thanks for this. I'll give it a proper look anon. 👍

@xordoquy
Copy link
Collaborator

I'll be fine if we already get the "infrastructure" part into master - i.e. up to the updated tox.
Should be fine since failure is allowed on the 2.0 build.

@carltongibson carltongibson added this to the 3.7.0 Release milestone Sep 25, 2017
@carltongibson
Copy link
Collaborator

@auvipy as per @xordoquy's comment, if you can split this into two I'll merge the first part today.

  1. Update tox/travis etc.
  2. Fixes for 2.0 compat (eventually making pass required...)

For 1. can you please Drop 1.8 as per #5058 (comment).

This will require a 3:

  • Clean-up 1.8 compat

... but I'd like to take that separately.

(Please rebase. Thanks!)

Thank you for the effort!

@gcbirzan
Copy link
Contributor

Btw, aside the changing of names, the other thing needed is a way to get the URL pattern from the new object. Initially, it was urlpattern.regex.pattern, it should now be urlpattern.pattern.regex.pattern. I guess a helper in compat could do this, this is where the old way is used: https://github.com/encode/django-rest-framework/search?utf8=%E2%9C%93&q=%22regex.pattern%22&type=

@carltongibson
Copy link
Collaborator

Closing in favour of #5457. @auvipy Thanks for the effort!

@auvipy auvipy deleted the dj2 branch May 23, 2018 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants