Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove instruction to pip install Django #7699

Closed
wants to merge 1 commit into from

Conversation

ckartchner
Copy link

Since #7063, where Django was added to the install_requires portion of setup.py
doing a separate pip install django has not been required for users of the framework

Today, usage instructions are inconsistent about whether they include that step. For example, the step is already omitted from the README.md Installation instructions, and on the homepage, while still including it elsewhere.

This PR supports the removal of all usage of "pip install Django" from project instructions.

@romainr
Copy link
Contributor

romainr commented Feb 12, 2021

👍

@xordoquy
Copy link
Collaborator

I'd rather keep it as it currently is.
If Django installation was indeed unnecessary, it would not need to be added into a new requirement file.
Beside, I'm fine that some step explicitly adds the Django installation step because user may think about adding the constraint on their Django version.

@xordoquy xordoquy closed this Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants