-
-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 3.7 #2744
Conversation
tests/test_config.py
Outdated
def test_ssl_config_support_for_keylog_file(tmpdir, monkeypatch): # pragma: no cover | ||
if sys.version_info > (3, 8): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment, this test works for 3.8 as well.
Cool, thanks. Dug out our discussion on dropping 3.6 to see what factors we used to help our decision here, which reminded me to check out pypi stats... |
Python 3.7 reached EOL, but packages still can support it (it just not accepts new security fixes). |
@tomchristie @T-256 Then, how is it better to proceed? To create one more PR with a deprecation warning, release a new version, and wait for the updated statistics for a few months? Or just wait? |
3.7 isn't really costing us anything at the moment. Perhaps we wait until 3.12 is imminent and then consider switching to supporting |
This is starting to impact our CI as other tools switch out... https://github.com/encode/httpx/pulls Perhaps our next release really should be a 0.25 with Python 3.8+ support? (Thanks for your patience @Pliner) |
+1. Give me a moment, I will be rebase the PR on top of the latest changes. |
9c8cd81
to
e99e294
Compare
@tomchristie Sorry, I incorrectly rebased this PR from the first attempt and GH closed it :( |
Summary
Python 3.7 EOL is approaching, this PR removes its support.
Related to #727.
Checklist