-
-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate WS_1004_NO_STATUS_RCVD
and WS_1005_ABNORMAL_CLOSURE
#1580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kludex Is this worth the effort as Python 3.6 is already EOL and there's plan to remove support in Starlette too?
I mean as you said we can hold it after Python 3.6 is removed.
I didn't say that, at least I didn't mean it. I mean that we should fix it before stop supporting Python 3.6, so at least the last version has it right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thanks @Kludex
So the idea here is to cut 1 release with those code then immediately remove it right? So:
Am I getting this right? |
Yes. |
The backport removal will be on the PR that drops Python 3.6. |
Closes #1578
This PR has the same idea as django/asgiref#272.
The idea here is to deprecate two constants using the PEP 562. Unfortunately I need to use a backport for Python 3.6 - but I guess we'd want to release this for Python 3.6 before removing the Python 3.6 support.
NOTE: After this PR gets in, a patch release is needed.