Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 0.27.0 #2147

Merged
merged 12 commits into from
May 16, 2023
Merged

Version 0.27.0 #2147

merged 12 commits into from
May 16, 2023

Conversation

aminalaee
Copy link
Member

@aminalaee aminalaee commented May 13, 2023 •
edited
Loading

Added

Fixed

Full Changelog: 0.26.1...0.27.0

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@aminalaee aminalaee marked this pull request as ready for review May 14, 2023 13:28
@Kludex
Copy link
Member

Kludex commented May 16, 2023

This is the right comparison: 0.26.1...master

Kludex
Kludex reviewed May 16, 2023
View reviewed changes
docs/release-notes.md Outdated Show resolved Hide resolved
Kludex
Kludex reviewed May 16, 2023
View reviewed changes
docs/release-notes.md Outdated Show resolved Hide resolved
@aminalaee
Copy link
Member Author

Wait for the new PR please

Kludex
Kludex reviewed May 16, 2023
View reviewed changes
docs/release-notes.md Outdated Show resolved Hide resolved
@Kludex
Copy link
Member

Kludex commented May 16, 2023

Wait for the new PR please

What are you talking about?

@aminalaee
Copy link
Member Author

I meant wait to add the new PR to release notes, it's looking good now 😄

Kludex
Kludex reviewed May 16, 2023
View reviewed changes
docs/release-notes.md Outdated Show resolved Hide resolved
@aminalaee
Copy link
Member Author

https://github.com/encode/starlette/releases/edit/untagged-49fcb838b4706d597c3a

@Kludex
Copy link
Member

Kludex commented May 16, 2023

Can you add a note in the release notes right below the date mentioning the advisory, and the link to it? Please

@Kludex
Copy link
Member

Kludex commented May 16, 2023

It's super hard to do stuff on the phone

@aminalaee
Copy link
Member Author

Sure, let me take care of this.

@Kludex
Copy link
Member

Kludex commented May 16, 2023

Also, create a GitHub release draft, please.

@aminalaee
Copy link
Member Author

aminalaee commented May 16, 2023 •
edited
Loading

I have created the draft and linked it here.

@Kludex
Copy link
Member

Kludex commented May 16, 2023

Looks good

Kludex
Kludex reviewed May 16, 2023
View reviewed changes
docs/release-notes.md Outdated Show resolved Hide resolved
Kludex
Kludex reviewed May 16, 2023
View reviewed changes
docs/release-notes.md Outdated Show resolved Hide resolved
Kludex
Kludex reviewed May 16, 2023
View reviewed changes
docs/release-notes.md Outdated Show resolved Hide resolved
@aminalaee aminalaee requested a review from Kludex May 16, 2023 10:56
@Kludex Kludex merged commit 0c4b68a into master May 16, 2023
@Kludex Kludex deleted the version-0.27.0 branch May 16, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aminalaee @Kludex