Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply AnyIO upgrade changes only on test suite #2229

Closed
wants to merge 1 commit into from
Closed

Conversation

Comment on lines +234 to +235
with convert_exc_groups():
response = client.get("/")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't supposed to raise an error. I'll investigate later.

@agronholm
Copy link
Contributor

Are you sure this is the right solution? You told me yourself that you'd prefer the singular exception from the exception group to be extracted and reraised. If you don't want to add exceptiongroup as a dependency yet, I think the exceptiongroup import just needs to be wrapped with a try...except ImportError. Then we can replace the context manager with a no-op.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No module named 'exceptiongroup' when upgraded to starlette 0.31.0
2 participants