Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port importer to new versions of dependencies #10

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Port importer to new versions of dependencies #10

wants to merge 8 commits into from

Conversation

foaly-nr1
Copy link

The current version of the importer doesn't run on Node 8. I've upgraded the dependencies and changed the script to use their current interfaces.

endSly
endSly reviewed Sep 21, 2017
View reviewed changes
Copy link
Owner

@endSly endSly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! let me review the changes and will merge

importer/import.js Outdated

for (count = 0; count < allItems.length; count++) {
write(allItems[count].innerHTML, allItems[count].href);
count++;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are incrementing count twice

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops! fixed

@foaly-nr1
Copy link
Author

foaly-nr1 commented Sep 21, 2017 •
edited
Loading

Don't forget to squash all my commits into one when you merge ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endSly endSly endSly left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foaly-nr1 @endSly