fleetctl: {load|unload|start|stop} and get unit code cleanups #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebuild this please |
|
retest this please |
test: added test scripts for the functional tests
…n_travis travis: bump go minor versions, add 1.6
Just make it a const var that can be used or adapted if needed later.
Add IsErrorUnitNotFound() and use it in destroy to check if the error indicates that the unit does not exist. For the moment we just want to check if the error is 'unit not found', if later we want more we may export a more generic function into cAPI.
…e conditions Make the test more smarter by checking for race conditions and output result. Sometimes you may see normal output sometimes no output between the two goroutines which is normal, the thing to worry about is if Destroy did success or not.
…mmands() Add newFakeRegistryForCommands() function so fleetctl command tests can use it. We will add stop and unload tests which will also use this function and commandTestResults struct.
…-tests-v1 fleetctl: destroy fix and more tests
tixxdz
force-pushed
the
tixxdz/fleet-code-cleaning-v1+1
branch
from
75dcaa0 to
e8a80b5
Compare
This wiki page is outdated http://www.freedesktop.org/wiki/Software/systemd/dbus/ Polkit rule was already implemented in this PR: coreos/coreos-overlay#1579
…t_note docs: remove D-Bus and polkit note, it is not true.
docs: purged CLI parameters info (was added by mistake)
* tryWaitForUnitStates() tries to wait for units to reach the desired state. * getBlockAttempts() gets the correct value of how many attempts to try before giving up on an operation. These helpers will be used to make the code more consistent and clean. We do not intended to change any behaviour here.
… getBlockAttempts()
…ileFromTemplate()
Improve code comments about getUnitFileFromTemplate() and kill some other useless code comments.
added 4 commits
March 2, 2016 13:51
…tion Improve getUnitFile() error handling and add some documentation to getUnitFileFromTemplate()
…th registry and filesystem
tixxdz
force-pushed
the
tixxdz/fleet-code-cleaning-v1+1
branch
from
d74b89e to
cab3099
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches set aims to make the code more consistent and robust. It does not change the current behaviour just improves the code, consolidate it, more debug logs and code comments.
The main goal is to let stop, start, load and unload to share the same code base and probably avoid any corner case or bug that may related to one of these commands.
Some logic can be easily shared later when we add stop to destroy command to solve coreos#1000
There were some TODOs in the code base that I cleaned up with the last two patches. These patches will make it easy for us to implement later coreos#1295