Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apple m1/arm64 support #177

Merged
merged 4 commits into from
Jun 3, 2021
Merged

Conversation

zenspider
Copy link
Contributor

@zenspider zenspider commented Jun 2, 2021

Fixes #176

@coveralls
Copy link

coveralls commented Jun 2, 2021

Coverage Status

Coverage remained the same at 90.348% when pulling 9b2cef1 on zenspider:zenspider/apple/m1 into c626073 on enkessler:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 89.955% when pulling 9b2cef1 on zenspider:zenspider/apple/m1 into c626073 on enkessler:master.

Copy link
Collaborator

@sds sds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

I will hold off on merging as @enkessler is working on migrating the test suite to GitHub Actions in #178. If they are good with merging this ahead of that work (seems like it would be fine to me) I am as well!

@enkessler
Copy link
Owner

Nice cleanup!

I will hold off on merging as @enkessler is working on migrating the test suite to GitHub Actions in #178. If they are good with merging this ahead of that work (seems like it would be fine to me) I am as well!

@sds Yeah, go for it. It shouldn't interfere at all.

@sds sds merged commit c8145d8 into enkessler:master Jun 3, 2021
@JoshCheek
Copy link

❤️ 🙏

@zenspider zenspider deleted the zenspider/apple/m1 branch June 6, 2021 20:05
@zenspider
Copy link
Contributor Author

Thank you! Could I bother you for a release? Looks clean since last.

@sds
Copy link
Collaborator

sds commented Jun 9, 2021

Released in 4.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should work for the M1 chip, but needs to be mapped or smth
5 participants