Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarity about resolution starting from L1 #360

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

gskril
Copy link
Member

@gskril gskril commented Nov 20, 2024

Also fixed a few broken code examples and inaccurate visuals (e.g. the primary name of 0x225...c3B5 is not luc.cash)

@gskril gskril requested a review from lucemans as a code owner November 20, 2024 20:34
@gskril gskril changed the title Add clarify about resolution starting from L1 Add clarity about resolution starting from L1 Nov 20, 2024
Copy link

Deploying ens-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: ce6a62d
Status: ✅  Deploy successful!
Preview URL: https://80d2d4ed.docs-bao.pages.dev
Branch Preview URL: https://wagmi-chainid.docs-bao.pages.dev

View logs

Copy link
Contributor

@lucemans lucemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucemans lucemans merged commit 9686d4e into master Nov 26, 2024
4 checks passed
@lucemans lucemans deleted the wagmi-chainid branch November 26, 2024 17:41
5ajaki added a commit to 5ajaki/ENS-docs that referenced this pull request Dec 15, 2024
* Patch L2 Reverse Name Link (ensdomains#355)

* Misc. fixes and improvements to "Resolvers" section (ensdomains#357)

* Typo corrections (ensdomains#345)

* Add clarity about resolution starting from L1 (ensdomains#360)

* fix: incorrect resolver address on EthRegistryDemo (ensdomains#368)

Co-authored-by: Greg <[email protected]>

* fix: min_commitment_age language (ensdomains#367)

* Bump cross-spawn from 7.0.3 to 7.0.6 in /app (ensdomains#366)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update connect modal (ensdomains#340)

* Create EP 5.27 (ensdomains#373)

* Fix DAO stewards' avatars (ensdomains#363)

* Add EP 5.22 (ensdomains#343)

Co-authored-by: Greg Skriloff <[email protected]>

* Bump nanoid from 3.3.7 to 3.3.8 in /app (ensdomains#374)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump secp256k1 from 5.0.0 to 5.0.1 in /app (ensdomains#335)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add EP 5.25 (ensdomains#358)

Co-authored-by: Greg Skriloff <[email protected]>

* Add EP 5.26 (ensdomains#359)

Co-authored-by: Greg Skriloff <[email protected]>

* Add EP 5.23 (ensdomains#376)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Luc van Kampen <[email protected]>
Co-authored-by: r4bbit <[email protected]>
Co-authored-by: Dmitry <[email protected]>
Co-authored-by: Greg <[email protected]>
Co-authored-by: CHANCE <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nick Johnson <[email protected]>
Co-authored-by: Agora Governance Bot <[email protected]>
@5ajaki 5ajaki mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants