implement random words passphrase generator #50

agusu · 2021-12-09T13:28:44Z

No description provided.

josematiasrivero · 2021-12-09T17:12:25Z

modules/fox-services/src/main/java/com/ensolvers/fox/services/RandomWordsPassphrase.java

+    private static String randomWords(int n)  {
+        try {
+            // Load english dictionary to memory
+            File dictionaryFile = new File("src/main/resources/words_alpha.txt");
+            Stream<String> dictionary = Files.lines(dictionaryFile.toPath());
+            List<String> wordList = dictionary.collect(Collectors.toList());
+            StringBuilder words = new StringBuilder();
+
+            int i = 0;
+            while (i < n) {
+                String currentWord = pickRandomItemFromList(wordList);
+                if (currentWord.length() > 3 && currentWord.length() < 8) {
+                    words.append(currentWord);
+                    if (i < n - 1) words.append(" ");
+                    ++i;
+                }
+            }
+
+            return words.toString();
+        } catch (IOException e) {
+            return RandomStringUtils.randomAlphanumeric(18);
+        }
+    }


Are you trying to do this every time you are requesting the words? generate() and generate(int) suggest that.

This is very inefficient.

Instead I would:

Apply the singleton pattern to this class (https://refactoring.guru/design-patterns/singleton/java/example)

Move all the methods to instance methods

Ensure that we are loading the dictionary only once, when neeed

Ensure that we are logging how much time does the dictionary to be loaded