fix potential null dereference in ext_authz #36268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: antoniovleonti <[email protected]>
|
those are real test failures, don't waste too much time looking at this yet. |
Signed-off-by: antoniovleonti <[email protected]>
Signed-off-by: antoniovleonti <[email protected]>
Signed-off-by: antoniovleonti <[email protected]>
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Oct 17, 2024
Commit Message: fix potential null dereference in ext_authz Additional Description: Previously, if ext_authz had emit filter state stats set to true and another filter added filter state under the ext authz filter's name, it would result in a null dereference. The member logging_info_ would not be set in initiateCall after seeing there was already data there. Later, we would dereference logging_info_ to update the stats as if it were initialized already. I've added a check for a null logging_info_ and added logging & a stat for when there's a filter state naming collision. I also made some readability improvements to the ext_authz test. Risk Level: low Testing: unit tested Docs Changes: none Release Notes: none Platform Specific Features: none --------- Signed-off-by: antoniovleonti <[email protected]> Signed-off-by: Gustavo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: fix potential null dereference in ext_authz
Additional Description:
Previously, if ext_authz had emit filter state stats set to true and another filter added filter state under the ext authz filter's name, it would result in a null dereference. The member logging_info_ would not be set in initiateCall after seeing there was already data there. Later, we would dereference logging_info_ to update the stats as if it were initialized already.
I've added a check for a null logging_info_ and added logging & a stat for when there's a filter state naming collision.
I also made some readability improvements to the ext_authz test.
Risk Level: low
Testing: unit tested
Docs Changes: none
Release Notes: none
Platform Specific Features: none