Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udp_proxy: improve retries by checking connect attempts immediately after failure #38243

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

udp_proxy: improve retries by checking connect attempts immediately after failure #38243

wants to merge 2 commits into from

Conversation

IssaAbuKalbein
Copy link
Contributor

Commit Message:
Additional Description:

  • Improve retries by checking connect attempts immediately after the upstream connect failure.
  • Prevent adding the same session more than once to cluster's sessions (it's not really a bug because absl::flat_hash_set is a hash set that only allows unique elements and the second attempt has no effect).

Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:

Issa Abu Kalbein added 2 commits January 28, 2025 19:56
improve udp proxy retries
e91ff72 
Signed-off-by: Issa Abu Kalbein <[email protected]>
fix minor bug
4917a88 
Signed-off-by: Issa Abu Kalbein <[email protected]>
@IssaAbuKalbein
Copy link
Contributor Author

/retest

1 similar comment
@IssaAbuKalbein
Copy link
Contributor Author

/retest

RyanTheOptimist
RyanTheOptimist reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@RyanTheOptimist RyanTheOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks sensible. Can we get test coverage for it?

@RyanTheOptimist
Copy link
Contributor

/wait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanTheOptimist RyanTheOptimist RyanTheOptimist left review comments

@mattklein123 mattklein123 Awaiting requested review from mattklein123 mattklein123 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@RyanTheOptimist RyanTheOptimist

Labels
waiting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IssaAbuKalbein @RyanTheOptimist