Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic_modules: adds integration tests #38285

Merged

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Feb 1, 2025

Commit Message: dynamic_modules: adds integration tests
Additional Description:

This adds various integration test cases for dynamic modules
that cover all currently implemented callbacks. While running
tests, I discovered a few edge cases around decodeData and
encodeData, so I fixed it.

Risk Level: low
Testing: added
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #38285 was opened by mathetake.

see: more, trace.

Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake mathetake marked this pull request as ready for review February 1, 2025 17:09
@mathetake
Copy link
Member Author

/assign @mattklein123

Signed-off-by: Takeshi Yoneda <[email protected]>
@mattklein123 mattklein123 enabled auto-merge (squash) February 1, 2025 17:42
@mattklein123 mattklein123 merged commit 6953061 into envoyproxy:main Feb 1, 2025
23 of 24 checks passed
@mathetake mathetake deleted the dynamicmodulesintegrationtests branch February 1, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants