-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: BackendTrafficPolicy DNSLookupFamily #5249
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5249 +/- ##
==========================================
+ Coverage 64.96% 65.03% +0.06%
==========================================
Files 214 214
Lines 33532 33532
==========================================
+ Hits 21785 21806 +21
+ Misses 10407 10389 -18
+ Partials 1340 1337 -3 ☔ View full report in Codecov by Sentry. |
b69dd8d
to
7b834cd
Compare
thanks @guydc, this looks good ! |
Some examples: nginx:
istio:
contour:
F5:
So, there's a variety of styles. |
api/v1alpha1/dns_types.go
Outdated
type DNSLookupFamily string | ||
|
||
const ( | ||
// IPv4Only means the DNS resolver will first perform a lookup for addresses in the IPv4 family. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thoughts on just IPv4
? its less to type, but will it confuse the user who is aware of the envoyproxy api enums?
bfecbf3
to
7c9ee30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
7c9ee30
to
0c53c02
Compare
* api: BackendTrafficPolicy DNSLookupFamily Signed-off-by: Guy Daich <[email protected]> * fix api Signed-off-by: Guy Daich <[email protected]> * fix enum Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Tim OBrien <[email protected]>
* api: BackendTrafficPolicy DNSLookupFamily Signed-off-by: Guy Daich <[email protected]> * fix api Signed-off-by: Guy Daich <[email protected]> * fix enum Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Tim OBrien <[email protected]>
* api: BackendTrafficPolicy DNSLookupFamily Signed-off-by: Guy Daich <[email protected]> * fix api Signed-off-by: Guy Daich <[email protected]> * fix enum Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Tim OBrien <[email protected]>
What type of PR is this?
What this PR does / why we need it:
Backend
resource, see Breaking change: Backend cluster DNS lookup is V4_PREFERRED #5247IpFamilies
.Which issue(s) this PR fixes:
Fixes #
Release Notes: In the implementation PR