Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare first PyPi release #3

Merged
merged 17 commits into from
May 9, 2023
Merged

Prepare first PyPi release #3

merged 17 commits into from
May 9, 2023

Conversation

lrq3000
Copy link
Collaborator

@lrq3000 lrq3000 commented May 7, 2023

Prepare for first release:

  • Add badges in README
  • Add me as a maintainer in pyproject.toml, to ensure PyPi automatic security system accepts me pushing the package
  • Check/tweak continuous deployment and secrets
  • More?...

Not ready to be merged!

lrq3000 added 2 commits May 8, 2023 01:52
Note: it's expected they will be broken for now, they will work once the first release gets pushed to PyPi

Signed-off-by: Stephen L. <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2023

Codecov Report

Merging #3 (da451f7) into main (6c5901b) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage   74.22%   74.22%           
=======================================
  Files           1        1           
  Lines          97       97           
  Branches       19       19           
=======================================
  Hits           72       72           
  Misses         14       14           
  Partials       11       11           
Flag Coverage Δ
unittests 74.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@lrq3000 lrq3000 added the enhancement New feature or request label May 7, 2023
@eobrain
Copy link
Owner

eobrain commented May 8, 2023

Hey Stephen, following up the discussion in #1 ...

I don't think it is worth it to make this project into a GitHub organization, so if you could send me instructions for setting the secrets, that would be great.

You can email me at eobrain AT proton.me

Or DM me at @eob on Twitter or at @[email protected] on Mastodon.

Thanks

@lrq3000
Copy link
Collaborator Author

lrq3000 commented May 8, 2023

Ok awesome, I sent you an e-mail with the secrets to add and the instructions, thank you very much! :D

Signed-off-by: Stephen L. <[email protected]>
@lrq3000 lrq3000 marked this pull request as ready for review May 8, 2023 21:50
lrq3000 added 11 commits May 8, 2023 23:51
Signed-off-by: Stephen L. <[email protected]>
…tchphrase/project description in README.md + bump v0.2.7

Signed-off-by: Stephen L. <[email protected]>
…uggy, so removing author as maintainer (already shown as author anyway)

Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
@lrq3000
Copy link
Collaborator Author

lrq3000 commented May 8, 2023

@eobrain This PR is ready! I already published a release from this branch, so I know it works.

I also added a logo I made, I'm not a graphist, so if you don't like it don't worry I won't take it badly :-) Let me know if you want to keep it or not:

https://github.com/eobrain/videogestalt/blob/prepare-first-release/resources/videogestalt_logo.png

@eobrain
Copy link
Owner

eobrain commented May 9, 2023

The logo is great!

@eobrain eobrain closed this May 9, 2023
@eobrain eobrain reopened this May 9, 2023
@lrq3000
Copy link
Collaborator Author

lrq3000 commented May 9, 2023

Thank you very much @eobrain ! :D

Sorry you had some difficulties to merge, it was because one unit test failed and it was not because of us but GitHub Actions sometimes failing to setup the test environment 😅 We can just re-run the failed unit-tests in these cases :-)

Everything is in order now, I'm merging, thank you very much for your help all along and your trust!

For the moment I don't think I have anything else to add, but maybe in the future I will try to optimize a bit the performance if I can find a way, notably by parallelization, we'll see in another PR if I can make it work :-)

@lrq3000 lrq3000 merged commit 7641dbf into main May 9, 2023
@lrq3000 lrq3000 deleted the prepare-first-release branch May 9, 2023 20:41
@lrq3000 lrq3000 changed the title Prepare first release Prepare first PyPi release May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants