Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual whitepoint editor does not work #169

Closed
ledoge opened this issue Sep 5, 2022 · 2 comments
Closed

Visual whitepoint editor does not work #169

ledoge opened this issue Sep 5, 2022 · 2 comments

Comments

@ledoge
Copy link

ledoge commented Sep 5, 2022

When I set "Whitepoint" to "Chromaticity Coordinates" in the Calibration tab and click the icon to open the visual whitepoint editor, I get the following error:

Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/DisplayCAL/display_cal.py", line
6623, in visual_whitepoint_editor_handler
    ) or display_name.startswith(b"Chromecast "):
TypeError: startswith first arg must be str or a tuple of str, not bytes

Unfortunately, making it work is not as easy as just changing the byte strings to strings there, as I got a wx-related error when I tried that.

p5k369 added a commit to p5k369/displaycal-py3 that referenced this issue Sep 10, 2022
- changed comparison values for display_name to str in function visual_whitepoint_editor_handler
- added uncritical integer conversion wherever needed in module wxVisualWhitepointEditor
@p5k369
Copy link
Collaborator

p5k369 commented Sep 10, 2022

Hey @ledoge thanks for finding those bugs. The first one you solved by yourself, the second one is completely unrelated to the first one, take a look at #175 if you want to try it locally or wait until it gets merged into dev.

eoyilmaz added a commit that referenced this issue Sep 15, 2022
@p5k369
Copy link
Collaborator

p5k369 commented Sep 15, 2022

Fixed in #175

@p5k369 p5k369 closed this as completed Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants