Cleanup: remove no-longer-referenced get_known_folder_path, UserDirs class #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4ea5bca.
…th method, and associated UserDirs class
|
Hm, I guess continuous integration didn't run for this pull request. See the downstream branch here for a demonstration of the test results before and after the change from 015753b is applied: https://github.com/jayaddison/displaycal-py3/commits/develop |
p5k369
requested changes
Jan 7, 2023
There was a problem hiding this comment.
Hey @jayaddison,
you are right. That function was used by the original author around 2017 and never since. I think it can be removed.
However, please do not commit to the main branch and instead to the develop branch.
|
Thank you, @p5k369 - merge branch updated. |
p5k369
approved these changes
Jan 7, 2023
|
You're welcome! Thank you for the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at a similar build failure to the one mentioned in #218, I noticed that the
UserDirsclass (XDG-related functionality) where a translation-retrieval exception occurred may be part of an unused section of code.As far as I can tell, the
UserDirsclass is only referenced by theget_known_folder_pathmethod, which is imported -- but not invoked -- byworker.py.I ran most tests for this locally, although I had some difficulty getting some of the tests to run in a containerized environment (so I'm leaning on continuous integration a bit, here).
(note for maintainers: this changeset currently applies cleanly to the
developbranch, if that's a better place to direct this change)