Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browsermob-proxy] remove hardcoded request timeout #59

Closed
tkohegyi opened this issue Aug 12, 2015 · 3 comments
Closed

[browsermob-proxy] remove hardcoded request timeout #59

tkohegyi opened this issue Aug 12, 2015 · 3 comments
Assignees
@tkohegyi

Comments

@tkohegyi
Copy link
Contributor

Wilma has a proxy.request.timeout value, but it is used by the browsermob-proxy for Wilma module only partially.
Need to make sure that the configurable item is in use - so eliminate the hardcoded values.
@tkohegyi tkohegyi added the bug label Aug 12, 2015
@tkohegyi tkohegyi self-assigned this Sep 24, 2015
@tkohegyi
Copy link
Contributor Author

First investigation result: Right now seems it is NOT an issue, because the hardcoded values in original Browsermob-proxy, is not used by Wilma. Investigation continues...

@tkohegyi tkohegyi removed the bug label Sep 27, 2015
@tkohegyi
Copy link
Contributor Author

Not bug. The hardcoded timeout value is not actively used by Wilma, and in addition, a huge part of browsermob-proxy code can be removed as not in use by Wilma.

tkohegyi added a commit that referenced this issue Sep 27, 2015
@tkohegyi
- remove big amount of browsermob-proxy code base that is not used by…
7bcb3e9 
… Wilma - see #59 (considered as addressed) and #14 (ongoing)
tkohegyi added a commit that referenced this issue Oct 2, 2015
@tkohegyi
preparing Wilma 1.2 release with new proxy - proxy part upgrade is pr…
b5b0f76 
…epared

- reduced content, optimizations in code and more separation from Wilma, addressing #14
- prepare eliminating further unnecessary code, see #14
- hardcoded timeout now eliminated, see #59
tkohegyi added a commit that referenced this issue Oct 5, 2015
@tkohegyi
Upgrading Wilma to use browsermob-proxy-for-wilma 1.2 version. The in…
4bfb074 
…terface of the proxy was changed and the possibility of optimizing the proxy code further was opened. See #14 and #59, those become available in Wilma with this upgrade.
@tkohegyi
Copy link
Contributor Author

tkohegyi commented Oct 9, 2015

ok, closing, will be released in V1.2.83

@tkohegyi tkohegyi closed this as completed Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkohegyi tkohegyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tkohegyi