fixing a bug causing disorder when resuming at an old wiki id #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
En gros avant le code assumait que dans df_reviews tous les wiki id pareil étaient regroupés mais c'est pas le cas du coup y'avait un bug quand on resume depuis un wiki id qu'on a déjà traiter avant bah il skippait aussi tous les wiki id qu'on traitait avant, donc maintenant plus simple, on assume qui ne va pas y avoir de problemes et le code juste resume à la row de df_review du nombre de row dans le tsv