Don't set "stop" field true if driver returns RA_PROBLEM true #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the driver's responsiblity to stop a motor if the condition that results in the RA_PROBLEM bit being set doesn't result in the motor automatically stopping. This partially reverts commit 303a920
tboegi
added a commit
to EuropeanSpallationSource/motor
that referenced
this pull request
Oct 2, 2018
Merge f6e9f26: "Merge: 741d429 26771f2" Date: Tue Aug 21 12:34:24 2018 -0500 Merge pull request epics-modules#109 from kmpeters/issue100 Don't set "stop" field true if driver returns RA_PROBLEM true Partially reverts commit 303a920 Fixes issue epics-modules#100: > There have been multiple problems caused by the motor record > sending a stop when the problem bit is set. > > One problem is discussed here: > https://epics.anl.gov/tech-talk/2018/msg01338.php > > The commit that introduced the stop is 303a920. > I vaguely recall the change being a workaround for less-than-idea > behavior of a motor controller, but neither @rsluiter nor I remember > which controller that was. > > Motor drivers should be modified to send the stop command when > the condition that triggers the setting of the problem bit is detected, > if needed. Remove the bit from .MFLG as well: modified: motorApp/MotorSrc/asynMotorController.cpp modified: motorApp/MotorSrc/asynMotorController.h modified: motorApp/MotorSrc/motor.h modified: motorApp/MotorSrc/motorRecord.cc Conflicts: motorApp/MotorSrc/motorRecord.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts commit 303a920
Fixes issue #100: