React Spectrum: Compat with React 19 types #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes eps1lon/DefinitelyTyped#30
Changes
forwardRef
render function was used as a component. This was a bug that couldn't be caught with types but now is. Previously the types assumed the second argument was legacy context. The fix was to wrap the render function inforwardRef
:1f9935a
(#1)useReducer
type parameters. The manual change is quite trivial and I never found more than one issue per repo. Still, worth a codemod but low pri: :NewuseReducer
typings types-react-codemod#375StoryFn(propsLike)
instead of<StoryFn {...propsLike} />
. I only illustrated the migration in one callsite:48971e8
(#1). There are too many to do manually. Worth to codemod this but I'm not working on it.createFactory
types without a need:d566212
(#1)Unresolved issues
framer-motion
uses the deprecated, global JSX namespace. Tracking in Libraries with issues DefinitelyTyped#25lucide-react
uses removedReactSVG
type. Tracking in Libraries with issues DefinitelyTyped#25