Fix dart analyze warnings

equalitie · Dec 2, 2024 · 5e06b58 · 5e06b58
1 parent c594c45
commit 5e06b58
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/bindings/dart/lib/client.dart b/bindings/dart/lib/client.dart
@@ -40,7 +40,9 @@ class Subscriptions {
   }
 
   void close() {
-    _sinks.values.forEach((sink) => sink.close());
+    for (var sink in _sinks.values) {
+      sink.close();
+    }
     _sinks.clear();
   }
 }

diff --git a/bindings/dart/lib/internal/message_matcher.dart b/bindings/dart/lib/internal/message_matcher.dart
@@ -1,7 +1,6 @@
 import 'dart:async';
 import 'dart:typed_data';
 import 'dart:collection';
-import 'package:flutter/services.dart';
 import 'package:msgpack_dart/msgpack_dart.dart';
 
 import '../client.dart';
@@ -103,7 +102,9 @@ class MessageMatcher {
     _isClosed = true;
     _subscriptions.close();
     final error = SessionClosed();
-    _responses.values.forEach((i) => i.completeError(error));
+    for (var i in _responses.values) {
+      i.completeError(error);
+    }
     _responses.clear();
   }
 

diff --git a/bindings/dart/lib/ouisync.dart b/bindings/dart/lib/ouisync.dart
@@ -59,9 +59,7 @@ class Session {
 
     final recvPort = ReceivePort();
 
-    if (bindings == null) {
-      bindings = Bindings.loadDefault();
-    }
+    bindings ??= Bindings.loadDefault();
 
     final result = _withPoolSync((pool) => bindings!.session_create(
           kind.encode(),