Add option to skip sorting in hashdiff for improved performance #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you advise on how the tests should look like? |
|
You could place your test in test_diff_tables. You can run a diff that only diffs one segment, so you can check that the order is preserved. (assuming the data has a non-sorted order) I think you can ensure one segment by putting a very low bisection-factor of 1 or 2, and high bisection threshold. |
alex-mirkin
force-pushed
the
skip-sort-results
branch
from
d53a156 to
af135cb
Compare
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to skip sorting results in
hashdifffor improved performance, when there is a large number of differences.When enabled, entries with the same key but different column values may not appear adjacent in the output.
This change discussed in #41.