Enhancement: Assert that normalization of JSON is skipped when not de…

…coding to object
ergebnis · Oct 9, 2018 · a2cfbf6 · a2cfbf6
1 parent c28f2e9
commit a2cfbf6
Showing 1 changed file with 43 additions and 3 deletions.
diff --git a/test/Unit/Normalizer/AbstractNormalizerTestCase.php b/test/Unit/Normalizer/AbstractNormalizerTestCase.php
@@ -33,9 +33,7 @@ final public function testNormalizeRejectsInvalidJson(): void
     {
         $json = $this->faker()->realText();
 
-        $reflection = new \ReflectionClass($this->className());
-
-        $normalizer = $reflection->newInstanceWithoutConstructor();
+        $normalizer = $this->createNormalizer();
 
         $this->expectException(\InvalidArgumentException::class);
         $this->expectExceptionMessage(\sprintf(
@@ -46,6 +44,41 @@ final public function testNormalizeRejectsInvalidJson(): void
         $normalizer->normalize($json);
     }
 
+    /**
+     * @dataProvider providerJsonNotDecodingToObject
+     *
+     * @param string $json
+     */
+    final public function testNormalizeDoesNotModifyWhenJsonDecodedIsNotAnObject(string $json): void
+    {
+        $normalizer = $this->createNormalizer();
+
+        $normalized = $normalizer->normalize($json);
+
+        $this->assertSame($json, $normalized);
+    }
+
+    public function providerJsonNotDecodingToObject(): \Generator
+    {
+        $faker = $this->faker();
+
+        $values = [
+            'array' => $faker->words,
+            'bool-false' => false,
+            'bool-true' => true,
+            'float' => $faker->randomFloat(),
+            'int' => $faker->randomNumber(),
+            'null' => null,
+            'string' => $faker->sentence,
+        ];
+
+        foreach ($values as $key => $value) {
+            yield $key => [
+                \json_encode($value),
+            ];
+        }
+    }
+
     final protected function className(): string
     {
         return \preg_replace(
@@ -58,4 +91,11 @@ final protected function className(): string
             )
         );
     }
+
+    private function createNormalizer(): Normalizer\NormalizerInterface
+    {
+        $reflection = new \ReflectionClass($this->className());
+
+        return $reflection->newInstanceWithoutConstructor();
+    }
 }