Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Use ergebnis/composer-json-normalizer instead of localheinz/composer-json-normalizer #261

Merged
merged 3 commits into from
Dec 15, 2019
Merged

Enhancement: Use ergebnis/composer-json-normalizer instead of localheinz/composer-json-normalizer #261

merged 3 commits into from
Dec 15, 2019

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Dec 15, 2019 •
edited
Loading

This PR

  • uses ergebnis/composer-json-normalizer instead of localheinz/composer-json-normalizer
  • uses ergebnis/json-normalizer instead of localheinz/json-normalizer
  • requires ergebnis/json-printer

@localheinz localheinz self-assigned this Dec 15, 2019
@localheinz localheinz force-pushed the feature/composer-json-normalizer branch 3 times, most recently from 3c2e185 to f1e93a0 Compare December 15, 2019 14:55
@localheinz localheinz force-pushed the feature/composer-json-normalizer branch from f1e93a0 to e1fa491 Compare December 15, 2019 14:57
@localheinz localheinz marked this pull request as ready for review December 15, 2019 14:58
@codecov
Copy link

codecov bot commented Dec 15, 2019 •
edited
Loading

Codecov Report

Merging #261 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #261   +/-   ##
=======================================
  Coverage        80%    80%           
  Complexity       43     43           
=======================================
  Files             3      3           
  Lines           175    175           
=======================================
  Hits            140    140           
  Misses           35     35
Impacted Files Coverage Δ Complexity Δ
src/NormalizePlugin.php 57.14% <ø> (ø) 3 <0> (ø) ⬇️
src/Command/NormalizeCommand.php 88.31% <100%> (ø) 36 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c4c5a0...2616455. Read the comment docs.

@localheinz localheinz merged commit e77658c into master Dec 15, 2019
@localheinz localheinz deleted the feature/composer-json-normalizer branch December 15, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@localheinz localheinz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@localheinz