Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Provide a changelog #94

Merged
merged 1 commit into from
Oct 21, 2018
Merged

Enhancement: Provide a changelog #94

merged 1 commit into from
Oct 21, 2018

Conversation

localheinz
Copy link
Member

This PR

  • provides a changelog

Fixes #92.

@localheinz localheinz self-assigned this Oct 19, 2018
@localheinz localheinz force-pushed the feature/changelog branch 3 times, most recently from 6e47a13 to 70410a8 Compare October 19, 2018 19:37
@localheinz localheinz mentioned this pull request Oct 19, 2018
Merged
1 task
@codecov
Copy link

codecov bot commented Oct 19, 2018 •
edited
Loading

Codecov Report

Merging #94 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #94   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity       74     74           
=======================================
  Files             7      7           
  Lines           275    275           
=======================================
  Hits            275    275

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb4eec2...ec217d4. Read the comment docs.

keradus
keradus reviewed Oct 20, 2018
View reviewed changes
CHANGELOG.md Outdated

### Added

*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it autogenerated?
if not, i would suggest to skip empty sections,

even keep a changelog skips empty sections in it's own changelog

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not (yet) autogenerated, just left them here so I have the right order.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep the order and simply leave filled points.

eg, for bugfix releases, you won't have any features, right ? no point to always have them present

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @keradus!

@localheinz localheinz merged commit 6df0fdc into master Oct 21, 2018
@localheinz localheinz deleted the feature/changelog branch October 21, 2018 10:27
@localheinz
Copy link
Member Author

Thank you, @keradus!

@SpacePossum
Copy link

@localheinz nice man 👍

@localheinz
Copy link
Member Author

Thank you, @SpacePossum! 🤓

This was referenced Nov 4, 2018
Merged
Merged
@keradus keradus mentioned this pull request Nov 18, 2018
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus left review comments

Assignees

@localheinz localheinz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@localheinz @SpacePossum @keradus