Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Ensure print() is idempotent #12

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Jan 5, 2018

This PR

  • ignore whitespace outside of string literals in original to ensure Printer::print() is idempotent

@localheinz localheinz self-assigned this Jan 5, 2018
@codecov
Copy link

codecov bot commented Jan 5, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@ad702b6). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #12   +/-   ##
=========================================
  Coverage          ?   96.49%           
  Complexity        ?       28           
=========================================
  Files             ?        1           
  Lines             ?       57           
  Branches          ?        0           
=========================================
  Hits              ?       55           
  Misses            ?        2           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
src/Printer.php 96.49% <100%> (ø) 28 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad702b6...858a713. Read the comment docs.

@localheinz localheinz force-pushed the feature/idempotency branch from 717b94e to 858a713 Compare January 5, 2018 08:03
@localheinz localheinz merged commit cdd589a into master Jan 5, 2018
@localheinz localheinz deleted the feature/idempotency branch January 5, 2018 08:03
@localheinz localheinz mentioned this pull request Jan 5, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant