Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

escape-string-regexp dependency breaking IE11 #540

Closed
mattfrey-gr opened this issue Apr 24, 2020 · 4 comments
Closed

escape-string-regexp dependency breaking IE11 #540

mattfrey-gr opened this issue Apr 24, 2020 · 4 comments
Labels
bug

Comments

@mattfrey-gr
Copy link

The version specified for the escape-string-regexp dependency contains an arrow function which is causing a syntax error in IE11 (sindresorhus/escape-string-regexp#18) escape-string-regexp^1.0.5 didn't have this problem so if you're not using the functionality in the newer versions downgrading it would be nice.
@ericgio
Copy link
Owner

ericgio commented Apr 24, 2020

@mattfrey-gr: thanks for the report. As noted in the linked issue, shouldn't this be handled by whatever tools the developer is using to transpile their code for the web (eg: webpack/babel)?

@ericgio
Copy link
Owner

ericgio commented Apr 24, 2020

Related issue with examples of how to configure webpack/babel: babel/babel-loader#171

ericgio added a commit that referenced this issue May 7, 2020
@ericgio
Incorporate escape-string-regexp function (#540)
5307b46
@ericgio
Copy link
Owner

ericgio commented May 7, 2020

Small lib, so just including the function in this package for now :/ Fixed in v4.2.3

@ericgio ericgio closed this as completed May 7, 2020
@mattfrey-gr
Copy link
Author

Thank you @ericgio!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericgio @mattfrey-gr