Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all Hive tests and include them into CI #11716

Closed
3 tasks done
yperbasis opened this issue Aug 22, 2024 · 2 comments · Fixed by #12469
Closed
3 tasks done

Fix all Hive tests and include them into CI #11716

yperbasis opened this issue Aug 22, 2024 · 2 comments · Fixed by #12469
Assignees
@somnathb1
Labels
imp1 High importance

Comments

@yperbasis
Copy link
Member

yperbasis commented Aug 22, 2024 •
edited by somnathb1
Loading

@yperbasis yperbasis self-assigned this Aug 22, 2024
@yperbasis yperbasis added the imp2 Medium importance label Aug 22, 2024
@yperbasis yperbasis mentioned this issue Aug 23, 2024
Closed
@yperbasis yperbasis added imp1 High importance and removed imp2 Medium importance labels Aug 27, 2024
@yperbasis yperbasis assigned somnathb1 and unassigned yperbasis Sep 20, 2024
@somnathb1
Copy link
Contributor

somnathb1 commented Sep 28, 2024 •
edited
Loading

Many of the issues at the tip of main branch are related to latest PRs on Erigon-3. It so happens that there are design changes happening all the time. The main focus of this issue would be to integrate the CI to automate the process of indicating which PR broke which hive test(s).
The next focus would be to include some fixes applied for some of the failures. Further fixes for one or more hive tests is too big for a scope of a single issue.

@AskAlexSharov
Copy link
Collaborator

Further fixes for one or more hive tests is too big for a scope of a single issue. - use it as an umbrella-issue: with many check-boxes/links_to_other_issues

@yperbasis yperbasis self-assigned this Sep 30, 2024
@somnathb1 somnathb1 linked a pull request Oct 24, 2024 that will close this issue
jsonrpc: Add totalDifficulty back as interim hive fix #12469
Merged
@yperbasis yperbasis removed their assignment Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@somnathb1 somnathb1

Labels
imp1 High importance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

jsonrpc: Add totalDifficulty back as interim hive fix erigontech/erigon
3 participants
@somnathb1 @yperbasis @AskAlexSharov