jsonrpc: Add totalDifficulty back as interim hive fix #12469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Unlikely that Hive would implement the changed specs right away. Must merge this for now. |
|
yeah - my opinion is "no thanks". it has been quite some time that the change was merged, and we even care about PoS transition tests being down? |
Giulio2002
approved these changes
Oct 28, 2024
|
whatever - i see |
|
@somnathb1 did you create issue in |
It's a good idea tho, but Hive team is aware of it. I don't wanna follow up on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until hive implements ethereum/execution-apis#570
Partial revert of https://github.com/erigontech/erigon/pull/11809/files
The reason this would still work with or without the snapshot files change:
totalDifficultyfield.