Updaing your Asset Manager

[fgoris]

Rob,

I made 2 minor changes, and added tests for both of them:

1. Updated to YUI Compressor 2.4.7 from 2.4.2. The old version was breaking CSS with @media tags.
2. Added a "minify" option to the JSON settings file. Defaults to true. Setting it to false lets you simply concat 3rd party JS that's already minified, in order to, for example, preserve the comments that contain the license terms.

Thanks!

-Frederik

[eroh92]

Can you separate out the "minify" commit into a separate pull request? I see what you are getting at here, but I'm not sure if this would be a preferred approach as it will not minify anything in the stack. If the goal is to leave the license info at the top of open source scripts, there may be a better way to denote those individual files.

[fgoris]

Good point. I'll pull that out and revisit it later. For now, the
budle-level setting serves our need, since we're putting all 3rd-party
scripts into one bundle. And, actually, now that I think of it, I might
have also minified some 3rd party scripts myself, added the header
comments back in, and checked them into source control (along with the
original, non-minified version). Having a way to specify "don't remove
the first comment in this file" would probably be better.

-Frederik

On 2/28/12 2:29 PM, "Rob Eroh"
<reply+i-3378938-d3cfee66d28158605f73cd1f1b1dbe580b58fd37-1069958@reply.git
hub.com> wrote:

Can you separate out the "minify" commit into a separate pull request? I
see what you are getting at here, but I'm not sure if this would be a
preferred approach as it will not minify anything in the stack. If the
goal is to leave the license info at the top of open source scripts,
there may be a better way to denote those individual files.

---

Reply to this email directly or view it on GitHub:
#1 (comment)