Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for protocol override #52

Open
RopoMen opened this issue Jan 2, 2017 · 0 comments
Open

Add support for protocol override #52

RopoMen opened this issue Jan 2, 2017 · 0 comments

Comments

@RopoMen
Copy link

RopoMen commented Jan 2, 2017

Currently used protocol http/https cannot be override.

I currently pass given url to this library without doing anything and this lib is parsing videoID from url given by end-user. This causes issues when end-user is giving http url to for example YouTube video, protocol cannot be override to https and it will break https sign in browser.

I also don't like the idea of manipulating given url before giving it to this lib, so I'll make PR's from this ticket over here :)
RopoMen pushed a commit to RopoMen/ng-videosharing-embed that referenced this issue Jan 2, 2017
erost#52, add protocol override support.
a2cf3f2
RopoMen pushed a commit to RopoMen/ng-videosharing-embed that referenced this issue Jan 2, 2017
erost#52, renamed attribute.
6d7c5e6
RopoMen pushed a commit to RopoMen/ng-videosharing-embed that referenced this issue Jan 2, 2017
erost#52, added missing minified file.
1839eda
RopoMen pushed a commit to RopoMen/ng-videosharing-embed that referenced this issue Jan 2, 2017
erost#52, added unit test.
de9a860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RopoMen