move to only support LTS and forward #131
Conversation
This allows to get rid of a bunch of llvm version checks
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #131 +/- ##
==========================================
- Coverage 88.49% 82.96% -5.54%
==========================================
Files 5 4 -1
Lines 565 540 -25
==========================================
- Hits 500 448 -52
- Misses 65 92 +27 ☔ View full report in Codecov by Sentry. |
| # - arch: "x64" | ||
| # os: "ubuntu-latest" | ||
| # version: "nightly" | ||
| julia-version: ['lts', '1'] |
There was a problem hiding this comment.
I think it's good to be explicit about version numbers since SIMD.jl has some low-level code. I'd write '1.10, 1.11 here.
| julia-arch: [x64, x86] | ||
| os: [ubuntu-latest, windows-latest, macOS-latest] | ||
| exclude: | ||
| - os: macOS-latest |
There was a problem hiding this comment.
macos-latest is now an ARM system. We should probably be explicitly about version numbers here and test on both macos-13 (x86-64) and macos-14 (arm64). The interesting thing here is that we can actually test on an ARM system!
It would probably also be good to be explicit about the Ubuntu and Windows versions.
|
Too complicated to address the review comments brought up so I will just leave this be. |
This allows to get rid of a bunch of llvm version checks