Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix FileIO deprecation #4

Merged
merged 2 commits into from
Sep 6, 2022
Merged

fix FileIO deprecation #4

merged 2 commits into from
Sep 6, 2022

Conversation

ExpandingMan
Copy link
Contributor

Getting deprecation warnings from FileIO, here's the fix.

@ExpandingMan
Copy link
Contributor Author

bump

1 similar comment
@ExpandingMan
Copy link
Contributor Author

bump

@ExpandingMan
Copy link
Contributor Author

@eschnett , pinging in case you are not watching the repo

@eschnett
Copy link
Owner

eschnett commented Sep 6, 2022

Thanks!

Does this still work with Julia 1.5?

@eschnett eschnett merged commit 58b1798 into eschnett:master Sep 6, 2022
@ExpandingMan
Copy link
Contributor Author

Didn't check 1.5.

@eschnett
Copy link
Owner

eschnett commented Sep 7, 2022

1.5 was broken for other reasons anyway, I updated the compat section to require 1.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ExpandingMan @eschnett