Add maybe_pm_hooks function for cache_user/rdbms_prefs

esl · Jun 17, 2021 · 5ff96d7 · 5ff96d7
1 parent ea1cec1
commit 5ff96d7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 20 deletions.
diff --git a/src/mam/mod_mam_cache_user.erl b/src/mam/mod_mam_cache_user.erl
@@ -78,18 +78,13 @@ start_server() ->
 hooks(HostType) ->
     PM = gen_mod:get_module_opt(HostType, ?MODULE, pm, false),
     MUC = gen_mod:get_module_opt(HostType, ?MODULE, muc, false),
-    case PM of
-        true ->
-            pm_hooks(HostType);
-        false ->
-            []
-    end ++
-    case MUC of
-        true ->
-            muc_hooks(HostType);
-        false ->
-            []
-    end.
+    maybe_pm_hooks(PM, HostType) ++ maybe_muc_hooks(MUC, HostType).
+
+maybe_pm_hooks(true, HostType) -> pm_hooks(HostType);
+maybe_pm_hooks(false, _HostType) -> [].
+
+maybe_muc_hooks(true, HostType) -> muc_hooks(HostType);
+maybe_muc_hooks(false, _HostType) -> [].
 
 pm_hooks(HostType) ->
     [{mam_archive_id, HostType, ?MODULE, cached_archive_id, 30},

diff --git a/src/mam/mod_mam_rdbms_prefs.erl b/src/mam/mod_mam_rdbms_prefs.erl
@@ -49,14 +49,13 @@ stop(HostType) ->
 hooks(HostType) ->
     PM = gen_mod:get_module_opt(HostType, ?MODULE, pm, false),
     MUC = gen_mod:get_module_opt(HostType, ?MODULE, muc, false),
-    case PM of
-        true -> pm_hooks(HostType);
-        false -> []
-    end ++
-    case MUC of
-         true -> muc_hooks(HostType);
-         false -> []
-    end.
+    maybe_pm_hooks(PM, HostType) ++ maybe_muc_hooks(MUC, HostType).
+
+maybe_pm_hooks(true, HostType) -> pm_hooks(HostType);
+maybe_pm_hooks(false, _HostType) -> [].
+
+maybe_muc_hooks(true, HostType) -> muc_hooks(HostType);
+maybe_muc_hooks(false, _HostType) -> [].
 
 pm_hooks(HostType) ->
     [{mam_get_behaviour, HostType, ?MODULE, get_behaviour, 50},