Skip to content

Commit

Permalink
Apply code review: fix typos, wrong descriptions
Browse files Browse the repository at this point in the history
  • Loading branch information
gustawlippa committed Aug 13, 2024
1 parent 9636520 commit e0e819c
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion doc/modules/mod_event_pusher_http.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,6 @@ Since Exometer doesn't support labels, the host types, or word `global`, are par
| ---- | ---- | -------------------------------------- |
| `[Host, mod_event_pusher_http_sent, count]` | spiral | An HTTP notification is sent successfully. |
| `[Host, mod_event_pusher_http_sent, failure_count]` | spiral | An HTTP notification failed. |
| `[Host, mod_event_pusher_http_sent, response_time]` | histogram | Does not include timings of failed requests. |
| `[Host, mod_event_pusher_http_sent, response_time]` | histogram | Time taken to send HTTP notification. Does not include timings of failed requests. |

[mod_event_pusher]: ./mod_event_pusher.md
8 changes: 4 additions & 4 deletions doc/modules/mod_ping.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,13 @@ Since Exometer doesn't support labels, the host types, or word `global`, are par
| Name | Type | Description (when it gets incremented) |
|------|------|----------------------------------------|
| `mod_ping_response_count` | counter | Client responds to a ping. |
| `mod_ping_response_time` | histogram | Ping request timeouts without a response from client. |
| `mod_ping_response_count` | counter | Response times (doesn't include timeouts). |
| `mod_ping_response_time` | histogram | Response times (doesn't include timeouts). |
| `mod_ping_response_count` | counter | Ping request timeouts without a response from client. |

=== "Exometer"

| Name | Type | Description (when it gets incremented) |
|------|------|----------------------------------------|
| `[HostType, mod_ping_response, count]` | spiral | Client responds to a ping. |
| `[HostType, mod_ping_response, time]` | histogram | Ping request timeouts without a response from client. |
| `[HostType, mod_ping_response_timeout, count]` | spiral | Response times (doesn't include timeouts). |
| `[HostType, mod_ping_response, time]` | histogram | Response times (doesn't include timeouts). |
| `[HostType, mod_ping_response_timeout, count]` | spiral | Ping request timeouts without a response from client. |
10 changes: 5 additions & 5 deletions doc/operation-and-maintenance/MongooseIM-metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ Since Exometer doesn't support labels, the host types are part of the metric nam
| `[HostType, c2s_element_out, iq_error_count]` | spiral | An IQ error is sent to a client. |
| `[HostType, c2s_element_out, message_error_count]` | spiral | A message error is sent to a client. |
| `[HostType, c2s_element_out, presence_error_count]` | spiral | A presence error is sent to a client. |
| `[HostType, c2s_message_processing_time`] | histogram | Processing time for incomming c2s stanzas. |
| `[HostType, c2s_message_processing_time`] | histogram | Processing time for incoming c2s stanzas. |
| `[HostType, sm_message_bounced, count]` | spiral | A `service-unavailable` error is sent, because the message recipient is offline. |
| `[HostType, router_stanza_dropped, count]` | spiral | A stanza is dropped due to an AMP rule or a `filter_local_packet` processing flow. |
| `[HostType, router_no_route_found, count]` | spiral | It is not possible to route a stanza (all routing handlers failed). |
Expand Down Expand Up @@ -446,7 +446,7 @@ Since Exometer doesn't support labels, the host types and backend actions are pa
| Metric name | Type | Description |
| ----------- | ---- | ----------- |
| `[HostType, BackendModule, BackendAction, count]` | spiral | Number of calls (spiral metric), incremented for *every* call (even a failed one). |
| `[HostType, BackendModule, BackendAction, time]` | histogram | Successful operation times. |
| `[HostType, BackendModule, BackendAction, time]` | histogram | Times of successful operations. |


Besides these, following authentication metrics are always available.
Expand All @@ -458,7 +458,7 @@ Since Exometer doesn't support labels, the host types are part of the metric nam
| Metric name | Type | Description |
| ----------- | ---- | ----------- |
| `auth_register_user_count` | counter | A user registered successfully. |
| `auth_unregister_user_count` | counter | A user unregistered sucessfully. |
| `auth_unregister_user_count` | counter | A user unregistered successfully. |
| `auth_authorize_count` | counter | A user tried to authorize. |
| `auth_authorize_time` | histogram | Time it took to authorize a user. |
| `auth_check_password_count` | counter | A password was checked. |
Expand All @@ -472,8 +472,8 @@ Since Exometer doesn't support labels, the host types are part of the metric nam

| Metric name | Type | Description |
| ----------- | ---- | ----------- |
| `[HostType, auth_register_user, count]` | spiral | A user registered sucessfully. |
| `[HostType, auth_unregister_user, count]` | spiral | A user unregistered sucessfully. |
| `[HostType, auth_register_user, count]` | spiral | A user registered successfully. |
| `[HostType, auth_unregister_user, count]` | spiral | A user unregistered successfully. |
| `[HostType, auth_authorize, count]` | spiral | A user tried to authorize. |
| `[HostType, auth_authorize, time]` | histogram | Time it took to authorize a user. |
| `[HostType, auth_check_password, count]` | spiral | A password was checked. |
Expand Down

0 comments on commit e0e819c

Please sign in to comment.