Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that user actually logouts in offline_SUITE tests #1681

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Ensure that user actually logouts in offline_SUITE tests #1681

merged 1 commit into from
Jan 23, 2018

Conversation

arcusfelis
Copy link
Contributor

@arcusfelis arcusfelis commented Jan 22, 2018 •
edited
Loading

Fixes

This PR addresses #1667 #1672 #1664

Proposed changes include:

  • Fix for failing offline tests
  • New helper function mongoose_helper:logout_user/2

fenek
fenek requested changes Jan 22, 2018
View reviewed changes
Copy link
Member

@fenek fenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use 4 spaces, not tabs. :)

@fenek fenek added ready and removed WIP 🚧 labels Jan 23, 2018
@fenek fenek merged commit ea350d5 into master Jan 23, 2018
@fenek fenek deleted the fix-offline-test branch January 23, 2018 15:55
@fenek fenek added this to the 3.0.0 milestone Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fenek fenek fenek approved these changes

Assignees
No one assigned
Labels
bug ci-errors ready tests
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@arcusfelis @fenek